Website: ERC-6982 Improving the comments in the interface #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All reviewers have approved. |
eip-review-bot
changed the title
|
Should I be allowed to merge the PR? |
sullof
changed the title
19 tasks
|
The commit 25e2a90 (as a parent of 54c04e7) contains errors. |
SamWilsn
approved these changes
Dec 12, 2023
eip-review-bot
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the clarity of the comments to the interface, following a conversation in the community about it.
@Pandapip1 This is my fourth attempt to make a minor change to the ERC. The previous ones produced errors in existing documents not changed by me. I aligned with master and I hope this time it passes. If not, I may close it and leave the description as is.