Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-6224: Move to Review #144

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Conversation

Arvolear
Copy link
Contributor

@Arvolear Arvolear commented Dec 5, 2023

Updated the specification, cleaned up texts, and added proper reference implementation.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Dec 5, 2023

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Update EIP-6224: Move to Review Update ERC-6224: Move to Review Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

The commit 5271599 (as a parent of 472e92b) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Dec 5, 2023
@github-actions github-actions bot removed the w-ci label Dec 5, 2023
ERCS/erc-6224.md Outdated Show resolved Hide resolved
ERCS/erc-6224.md Outdated Show resolved Hide resolved
SamWilsn
SamWilsn previously approved these changes Jan 9, 2024
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these comments when you have the chance!

ERCS/erc-6224.md Outdated Show resolved Hide resolved
assets/erc-6224/diagram.png Outdated Show resolved Hide resolved
@eip-review-bot eip-review-bot enabled auto-merge (squash) January 9, 2024 15:33
eip-review-bot
eip-review-bot previously approved these changes Jan 9, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled January 11, 2024 10:11

Head branch was pushed to by a user without write access

@Arvolear Arvolear dismissed stale reviews from eip-review-bot and SamWilsn via 8a86f37 January 11, 2024 10:11
@Arvolear
Copy link
Contributor Author

Hey @SamWilsn, please take a look.

Copy link

github-actions bot commented Feb 6, 2024

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@eip-review-bot eip-review-bot enabled auto-merge (squash) February 6, 2024 15:42
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 5eb98ee into ethereum:master Feb 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants