Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC: ERC-20 Holder Extension for NFTs #187

Merged
merged 13 commits into from
Jan 9, 2024
Merged

Add ERC: ERC-20 Holder Extension for NFTs #187

merged 13 commits into from
Jan 9, 2024

Conversation

steven2308
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jan 5, 2024 •
edited
Loading

✅ All reviewers have approved.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

The commit 0654f0c (as a parent of 867007a) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Jan 5, 2024
@eip-review-bot eip-review-bot changed the title Add ERC: ERC20 Holder Extension for NFTs. Add ERC: ERC20 Holder Extension for NFTs Jan 8, 2024
@github-actions github-actions bot removed the w-ci label Jan 8, 2024
@eip-review-bot eip-review-bot changed the title Add ERC: ERC20 Holder Extension for NFTs Add ERC: ERC-20 Holder Extension for NFTs Jan 8, 2024
@steven2308 steven2308 mentioned this pull request Jan 8, 2024
Closed
17 tasks
SamWilsn
SamWilsn reviewed Jan 9, 2024
View reviewed changes
ERCS/erc-7590.md Outdated Show resolved Hide resolved
ERCS/erc-7590.md Show resolved Hide resolved
assets/erc-7590/contracts/AbstractERC7590.sol Outdated Show resolved Hide resolved
@eip-review-bot eip-review-bot enabled auto-merge (squash) January 9, 2024 15:21
eip-review-bot
eip-review-bot approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eip-review-bot
eip-review-bot approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 7fccd9c into ethereum:master Jan 9, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@eip-review-bot eip-review-bot eip-review-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

Assignees
No one assigned
Labels
c-new e-consensus e-review s-draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steven2308 @eip-review-bot @abcoathup @SamWilsn