Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Move ERC-7007 to Last Call #461

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Conversation

socathie
Copy link
Contributor

@socathie socathie commented Jun 3, 2024

  • moving to Last Call, with a deadline of 2024-09-30
  • after peer review and referencing existing dApp implementation of this ERC, changing the specified mint interface to addAigcData

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jun 3, 2024

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Update ERC-7007: Move to Last Call Website: Move to Last Call Jun 3, 2024
@socathie socathie changed the title Website: Move to Last Call Update ERC-7007: Move to Last Call Jun 3, 2024
@@ -56,34 +58,24 @@ pragma solidity ^0.8.18;
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm that the above interface id is still correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out. Fixed in 23e5b00

@eip-review-bot eip-review-bot changed the title Update ERC-7007: Move to Last Call Website: Move to Last Call Aug 8, 2024
ERCS/erc-7007.md Outdated
@@ -4,7 +4,8 @@ title: Verifiable AI-Generated Content Token
description: An ERC-721 extension for verifiable AI-generated content tokens using Zero-Knowledge and Optimistic Machine Learning techniques
author: Cathie So (@socathie), Xiaohang Yu (@xhyumiracle), Conway (@0x1cc), Lee Ting Ting (@tina1998612), Kartin <[email protected]>
discussions-to: https://ethereum-magicians.org/t/eip-7007-zkml-aigc-nfts-an-erc-721-extension-interface-for-zkml-based-aigc-nfts/14216
status: Review
status: Last Call
last-call-deadline: 2024-06-30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend setting this to somewhere in late September, or allowing Maintainers to edit your pull request. Alternatively, you could come on our biweekly Office Hours call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have edited the deadline to the end of September. Unfortunately, we could not enable maintainers' editing since the forked repo is under a GitHub org (see https://github.com/orgs/community/discussions/5634)

@socathie socathie changed the title Website: Move to Last Call Website: Move ERC-7007 to Last Call Aug 14, 2024
@eip-review-bot eip-review-bot enabled auto-merge (squash) August 20, 2024 14:20
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 6e37a79 into ethereum:master Aug 20, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants