-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ERC-3009: Move to Draft #504
Conversation
File
|
Isn't anyone going to review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can approve this as an Editor, but you'll need to wait for one of the proposal authors to approve the pull request before it is merged.
Alternatively, if you'd like to champion this proposal, you can copy the text into a new proposal (adding yourself as an author) pull request.
The commit 4f950c2 (as a parent of 302c0c5) contains errors. |
@SamWilsn Thank you for your review. |
@dongri to create a new ERC please create the PR in the ERC repo. An ERC number will be manually assigned by an editor/associate. |
@abcoathup Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We make a better marketing world
There is an error in signature verification with the current sample code.
It is necessary to change the order of
bytes32(chainId)
andaddress(this)
to comply withkeccak256("EIP712Domain(string name,string version,uint256 chainId,address verifyingContract)")
.