Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-3009: Move to Draft #504

Closed
wants to merge 15 commits into from

Conversation

dongri
Copy link
Contributor

@dongri dongri commented Jun 22, 2024

There is an error in signature verification with the current sample code.

EIP3009: invalid signature

It is necessary to change the order of bytes32(chainId) and address(this) to comply with keccak256("EIP712Domain(string name,string version,uint256 chainId,address verifyingContract)").

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jun 22, 2024

File ERCS/erc-3009.md

Requires 1 more reviewers from @DavidLKnott, @kbrizzle, @petejkim

@dongri
Copy link
Contributor Author

dongri commented Jun 27, 2024

Isn't anyone going to review it?

@eip-review-bot eip-review-bot changed the title Update ERC-3009: Change the order of chainId and verifyingContract address Update ERC-3009: Move to Draft Aug 20, 2024
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve this as an Editor, but you'll need to wait for one of the proposal authors to approve the pull request before it is merged.

Alternatively, if you'd like to champion this proposal, you can copy the text into a new proposal (adding yourself as an author) pull request.

@github-actions github-actions bot added the w-ci label Aug 20, 2024
Copy link

The commit 4f950c2 (as a parent of 302c0c5) contains errors.
Please inspect the Run Summary for details.

@dongri
Copy link
Contributor Author

dongri commented Aug 20, 2024

I can approve this as an Editor, but you'll need to wait for one of the proposal authors to approve the pull request before it is merged.

Alternatively, if you'd like to champion this proposal, you can copy the text into a new proposal (adding yourself as an author) pull request.

@SamWilsn Thank you for your review.
When submitting a pull request with a new proposal, do I need to change the EIP number? Should it be +1 from the latest EIP?

@dongri
Copy link
Contributor Author

dongri commented Aug 20, 2024

@abcoathup
Copy link
Contributor

@dongri to create a new ERC please create the PR in the ERC repo. An ERC number will be manually assigned by an editor/associate.

@dongri
Copy link
Contributor Author

dongri commented Aug 21, 2024

@abcoathup Thanks!
#598

@SamWilsn SamWilsn closed this Aug 27, 2024
Copy link

@Jcpayvoice23 Jcpayvoice23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We make a better marketing world

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants