Update ERC-7208: Move to Review #568
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| --- | ||
| eip: 7208 | ||
| title: On-Chain Data Container | ||
| description: Interoperability by abstracting logic away from storage | ||
| author: Rachid Ajaja <[email protected]>, Alexandros Athanasopulos (@Xaleee), Pavel Rubin (@pash7ka), Sebastian Galimberti Romano (@galimba) | ||
| discussions-to: https://ethereum-magicians.org/t/erc-7208-on-chain-data-container/14778 | ||
| status: Draft | ||
|
|
@@ -271,6 +271,8 @@ | |
| **This example has not been audited and should not be used in production environments.** | ||
|
|
||
|
|
||
| See [Minimalistic Data Index](https://github.com/NexeraProtocol/Minimalistic-Data-Index) implementation. | ||
|
Check failure on line 274 in ERCS/erc-7208.md
|
||
|
|
||
|
|
||
| ## Security Considerations | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Reference implementation of ERC-7208 and usage examples | ||
| ## List of contracts | ||
| ### Interfaces | ||
| - [IDataIndex](./interfaces/IDataIndex.sol) - Interface of Data Index | ||
| - [IDataObject](./interfaces/IDataObject.sol) - Interface of Data Object | ||
| - [IDataPointRegistry](./interfaces/IDataPointRegistry.sol) - Interface of Data Point Registry | ||
| - [IIDManager](./interfaces/IIDManager.sol) - Interface for buildinq and quering Data Index user identifiers | ||
|
|
||
| ### Implementation | ||
| - [DataIndex](./DataIndex.sol) - Data Index (implements `IDataIndex` and `IIDManager`) | ||
| - [DataPointRegistry](./DataPointRegistry.sol) - Data Point Registry (implements `IDataPointRegistry`) | ||
| - [DataPoints](./utils/DataPoints.sol) - Library implementing DataPoint type and its encode/decode functions | ||
| - [OmnichainAddresses](./utils/OmnichainAddresses.sol) - Library implementing OmnichainAddress type which combines address and chain id | ||
| - [ChainidTools](./utils/ChainidTools.sol) - Library implementing utility functions to work with chain ids | ||
|
|
||
| ### Usage examples | ||
| - [IFractionTransferEventEmitter](./interfaces/IFractionTransferEventEmitter.sol) - Interface used for DataManagers communication to emit ERC20 Transfer events | ||
| - [IFungibleFractionsOperations](./interfaces/IFungibleFractionsOperations.sol) - Interface defines DataObject operations, which can be called by DataManager | ||
| - [MinimalisticFungibleFractionsDO](./dataobjects/MinimalisticFungibleFractionsDO.sol) - DataObject implements data storage and related logic for token with Fungible Fractions (like ERC1155) | ||
| - [MinimalisticERC1155WithERC20FractionsDataManager](./datamanagers/MinimalisticERC1155WithERC20FractionsDataManager.sol) - DataManager implements token with fungible fractions with ERC1155 interface, linked to a DataManager which implements ERC20 interface for same token | ||
| - [MinimalisticERC20FractionDataManager](./datamanagers/MinimalisticERC20FractionDataManager.sol) - implements token with ERC20 interface, linked to a DataManager which implements ERC1155 interface for same token | ||
| - [MinimalisticERC20FractionDataManagerFactory](./datamanagers/MinimalisticERC20FractionDataManagerFactory.sol) - factory of DataManagers implementing ERC20 interface for token with fungible fractions |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter is correct here. For the reasons enumerated here, please remove this external link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SamWilsn ,
I've removed the external link replacing it with the link to README.md, as you've suggested in the comment above.
But now the HTML prufer fails with
which was the reason we've tried with external repo.
Do you have any ideas how to fix it?