This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
[WIP] libtesteth: add transaction RLP to state tests #4254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every use of the netId field is wrapped in netIdToString, just store that string.
Also use set instead of vector.
The general state test format changes so the post state includes the RLP of the (signed) transaction. This makes it easier to run the tests because no signing is required. It's also slightly more powerful because any signature scheme can be tested.
|
I think those changes are breaking other test suites. |
|
here is the way to add transaction RLP could we split refactoring commits into smaller PR's ? |
|
I can send the refactoring as a separate PR if you want. |
|
I will reopen this some other time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general state test format changes so the post state includes the RLP
of the (signed) transaction. This makes it easier to run the tests
because no signing is required. It's also slightly more powerful because
any signature scheme can be tested.
The first few commits are refactoring changes.