Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Rename to aleth #5066

Merged
merged 4 commits into from
Jun 14, 2018
Merged

Rename to aleth #5066

merged 4 commits into from
Jun 14, 2018

Conversation

chfast
Copy link
Member

@chfast chfast commented Jun 6, 2018

No description provided.

@chfast chfast requested review from pirapira and gumb0 June 6, 2018 11:01
@codecov-io
Copy link

codecov-io commented Jun 6, 2018

Codecov Report

Merging #5066 into develop will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5066      +/-   ##
===========================================
+ Coverage    58.71%   58.72%   +0.01%     
===========================================
  Files          334      334              
  Lines        26424    26424              
  Branches      3133     3133              
===========================================
+ Hits         15514    15517       +3     
+ Misses        9909     9905       -4     
- Partials      1001     1002       +1

@@ -8,7 +8,6 @@ cpp-ethereum is a distribution of software including a number of diverse tools.
The full software suite of cpp-ethereum includes:

- **eth** (`eth`) The mainline CLI Ethereum client. Run it in the background and it will connect to the Ethereum network; you can mine, make transactions and inspect the blockchain.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about this line?

@@ -256,23 +256,23 @@ All restored!

Because our keys all share the same format it's really easy to import keys from other clients like Geth. In fact it's exactly the same process as restoring a key from a previous backup as we did in the last step.

If we assume we have a geth key at `mygethkey.json`, then to import it to use `eth`, simply use:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is about importing keys from geth, it should stay mygethkey.json

Copy link
Member

@gumb0 gumb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor notes

@chfast chfast force-pushed the rename-to-aleth branch from 5e22fc6 to e06bc19 Compare June 11, 2018 10:52
@chfast
Copy link
Member Author

chfast commented Jun 11, 2018

Fixed.


```
> ethkey import mygethkey.json "My Old Geth Key"
> aleth-key import mygaleth-key.json "My Old Geth Key"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mygeth-key.json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@chfast chfast force-pushed the rename-to-aleth branch from e06bc19 to 2683474 Compare June 11, 2018 14:23
@chfast chfast merged commit a3f2afe into develop Jun 14, 2018
@chfast chfast deleted the rename-to-aleth branch June 14, 2018 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants