This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Use storage status from EVMC #5171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5171 +/- ##
==========================================
- Coverage 59.9% 59.88% -0.03%
==========================================
Files 337 337
Lines 27350 27353 +3
Branches 3179 3181 +2
==========================================
- Hits 16385 16379 -6
- Misses 9880 9888 +8
- Partials 1085 1086 +1 |
chfast
force-pushed
the
evmc-storage-status
branch
from
48f21d5 to
45785cd
Compare
gumb0
approved these changes
Aug 9, 2018
chfast
commented
Aug 9, 2018
libaleth-interpreter/VM.cpp
Outdated
| m_context->fn_table->set_storage(m_context, &m_message->destination, &key, &value); | ||
| m_runGas = (status == EVMC_STORAGE_ADDED) ? VMSchedule::sstoreSetGas : | ||
| VMSchedule::sstoreResetGas; | ||
| updateIOGas(); // Update the gas after the change when the full cost is known. |
There was a problem hiding this comment.
I see one problem here. When we have 0 gas left, we will do a contract storage lookup (which should cost at least 200). Maybe we should charge sstoreResetGas up front, and then optionally VMSchedule::sstoreSetGas - VMSchedule::sstoreResetGas?
BTW, wasn't the cost of deletion 0 in Frontier?
There was a problem hiding this comment.
Sounds reasonable, charging upfront shouldn't hurt...
I think store costs didn't change since Frontier, only sload cost changed once.
chfast
force-pushed
the
evmc-storage-status
branch
from
45785cd to
da0e578
Compare
chfast
commented
Aug 9, 2018
gumb0
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ethereum/evmc#52.