Add peers v2 without meta #384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
Dec 8, 2023
|
This feels like a lot of bother for a small aesthetic nuisance in a fringe interface.. |
Also true, taking the counter argument there's really no harm in sticking with this oddity that already handled by all implementations. |
|
It is an outlier and hence needs some special handling during parsing if you implement a generic http client/server. It's a minor thing but probably not wrong to get rid of technical debt. |
|
Sounds like maybe we close the issue as 'won't fix'? |
This was referenced Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/eth/v1/node/peers#366Any consumer can derive the number of items by just doing
len(data). Creating a new route as a property is deleted from the response objectCloses #366