Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 404 response to states validator_balances #385

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Add 404 response to states validator_balances #385

merged 2 commits into from
Dec 10, 2023

Conversation

dapplion
Copy link
Member

@dapplion dapplion commented Dec 8, 2023

states validator_balances routes are missing the 404 response status that every other states/* route has to denote unknown state_id

Closes #378

rolfyone
rolfyone approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfyone rolfyone merged commit a6a7387 into master Dec 10, 2023
5 checks passed
@rolfyone rolfyone deleted the balances_404 branch December 10, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing 404 for /eth/v1/beacon/states/{state_id}/validator_balances and similar
2 participants
@dapplion @rolfyone