Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump-my-version and release fixes #27

Merged
merged 1 commit into from
Jan 21, 2025
Merged

bump-my-version and release fixes #27

merged 1 commit into from
Jan 21, 2025

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Jan 21, 2025 •
edited
Loading

What was wrong?

Missed a couple bump-my-version things in the previous PR.

How was it fixed?

made better

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes

Cute Animal Picture

image

@pacrob pacrob requested review from kclowes, reedsa and fselmo January 21, 2025 19:51
reedsa
reedsa approved these changes Jan 21, 2025
View reviewed changes
Copy link

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pacrob pacrob merged commit 08bba0b into ethereum:main Jan 21, 2025
27 checks passed
@pacrob pacrob deleted the bump-fixes branch January 21, 2025 22:02
@pacrob pacrob self-assigned this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reedsa reedsa reedsa approved these changes

@kclowes kclowes Awaiting requested review from kclowes

@fselmo fselmo Awaiting requested review from fselmo

Assignees

@pacrob pacrob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacrob @reedsa