Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some phase1 refactoring - part2 #1855

Merged
merged 7 commits into from
Jun 1, 2020
Merged

Some phase1 refactoring - part2 #1855

merged 7 commits into from
Jun 1, 2020

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented May 28, 2020

  1. Minor refactoring
  2. Add some more comments
  3. Refactor is_valid_indexed_attestation: extracting phase 1 only verify_attestation_custody
  4. Remove useless assertions from get_shard_transition

@hwwhww hwwhww added phase1 general:presentation Presentation (as opposed to content) labels May 28, 2020
@hwwhww hwwhww requested a review from djrtwo May 28, 2020 19:31
djrtwo
djrtwo approved these changes May 31, 2020
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent refactors!! :)

specs/phase1/beacon-chain.md Outdated Show resolved Hide resolved
@hwwhww hwwhww merged commit 09d8636 into dev Jun 1, 2020
@hwwhww hwwhww deleted the hwwhww/phase1_refactor_part2 branch June 1, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
general:presentation Presentation (as opposed to content) phase1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwwhww @djrtwo