-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposer LMD Score Boosting #2730
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
97e6d5c
Merge branch 'fc-dev-validate_target_epoch_scope-patch' into dev
djrtwo 7736c8b
Merge branch 'dev' of github.com:ethereum/eth2.0-specs into dev
djrtwo 2d161b4
Add proposer score boosting & related tests
adiasg 281c1b2
Update validator guide with ATTESTATION_OFFSET_QUOTIENT
adiasg 47fa6d1
Add parameter for score boost value
adiasg 504d82c
Add datatype to new parameters
adiasg b0fb861
Make PROPOSER_SCORE_BOOST a percentage value
adiasg 3b20e3e
Apply suggestions from code review
adiasg 859bbf4
This reverts commit 4c726cdff39a10c5d096b294fb562cfc99c1f068.
adiasg 88c76ab
Apply Danny's code review
adiasg cebe6ba
minor formatting cleanups
djrtwo 282d85b
simplify on_tick proposer boost update
djrtwo ea09df5
toc
djrtwo 1d835c5
Apply Danny's code review & suggestions
adiasg d85d439
Rename test
adiasg 64b4ca2
add PROPOSER_SCORE_BOOST to configuration yaml files
djrtwo bdd7b07
Add configuration value checks
hwwhww a0b5a80
Apply HWW code's review - fix is_before_attesting_interval
adiasg ecbe919
Apply HWW code's review - properly update test steps
adiasg 2a5c9d8
Set PROPOSER_SCORE_BOOST to 70%
adiasg 6f95637
Merging local branch to remote latest
adiasg 2ba0586
Add `proposer_boost_root` field to test vector "checks" step
hwwhww 40f1c85
Merge pull request #2736 from ethereum/proposer-score-boost-add-check
djrtwo 975931b
pr feedback
djrtwo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicking: we use
SECONDS_PER_SLOT // INTERVALS_PER_SLOT
in code and have setSECONDS_PER_SLOT % INTERVALS_PER_SLOT == 0
. It could be a bit off whenSECONDS_PER_SLOT % INTERVALS_PER_SLOT != 0
.Is
SECONDS_PER_SLOT % INTERVALS_PER_SLOT == 0
an invariant that should be checked intest_config_invariants.py
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that this is division and not integer division.
I don't think this makes sense as a strict config invariant but maybe deserves a note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDITED: Sorry, I meant "we use
SECONDS_PER_SLOT // INTERVALS_PER_SLOT
in code ".^^^^^ typo fixed
Yes. Clarify: so the value that the validator guide describes may be different from the value from the fork choice rule code when
SECONDS_PER_SLOT % INTERVALS_PER_SLOT != 0
.INTERVALS_PER_SLOT := 3
is fine for our minimal and mainnet config.Another option is also using integer division here: "...
SECONDS_PER_SLOT // INTERVALS_PER_SLOT
seconds after the start ofslot
..."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, right. Then it is valuable to have these work well together.