Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore finalization in minimum_request_epoch #3211

Closed
wants to merge 1 commit into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Jan 14, 2023

This issue is closed with conclusion that finalization should be ignored when considering blobs. #3141

This issue is closed with conclusion that finalization should be ignored when considering blobs.
ethereum#3141
@emhane
Copy link
Member Author

emhane commented Jan 14, 2023

Maybe, this issue is also related to that parameter #3204 (thanks @realbigsean)

@djrtwo
Copy link
Contributor

djrtwo commented Jan 16, 2023

ByRoot method is a separate issue than the serving of blobs to some deep depth ByRange.

As noted in the phase 0 p2p spec for the BlocksByRoot request:

Clients MUST support requesting blocks since the latest finalized epoch.

ByRoot methods require more load/sophistication because they can requested in any order. Thus these are only specified as MUST be available in the time since finality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants