Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Rabby Wallet #13469

Closed
1 of 2 tasks
vvvvvv1vvvvvv opened this issue Jul 24, 2024 · 7 comments
Closed
1 of 2 tasks

Update: Rabby Wallet #13469

vvvvvv1vvvvvv opened this issue Jul 24, 2024 · 7 comments
Assignees
Labels
awaiting PR Issue is ready for a pull request product 🧰 This involves a product listing Status: Stale This issue is stale because it has been open 30 days with no activity. wallet 👛 This issue relates to adding or changing a wallet

Comments

@vvvvvv1vvvvvv
Copy link
Contributor

vvvvvv1vvvvvv commented Jul 24, 2024

Wallet name

Rabby Wallet

What type of wallet?

EOA

Wallet description

The game-changing wallet for Ethereum and all EVM chains

Wallet logo

avatar

Background color for brand logo

#fff

URL to the project

https://rabby.io/

When did the wallet go live to users?

Jun 18, 2021

What are the fees users may be paying for using your wallet product?

0.25% fee for swapping and bridging

Does the wallet have an active development team?

https://github.com/RabbyHub/Rabby

Is the wallet globally accessible?

No

Is the wallet available in multiple languages?

  • English
  • Simplified Chinese
  • Traditional Chinese
  • German
  • Spanish
  • Japanese
  • French
  • Brazilian Portuguese
  • Turkish
  • Ukrainian
  • Russian

What social links are there for the project?

https://x.com/Rabby_io
https://discord.com/invite/seFBCWmUre

Does the wallet have a mobile app? If yes, which operating systems are supported (iOS, Android)?

Does the wallet have a desktop app? If yes, which operating systems are supported (Windows, Mac, Linux)?

Does the wallet have a browser extension? If yes, which browsers are supported (Chromium, Firefox, Safari)?

Is it a hardware wallet?

No, it's a hot wallet but support hardware wallet including Ledger, Trezor, GridPlus, OneKey, Keystone, Bitbox02, CoolWallet etc

What is the availability of your source code?

Open source

What license is the wallet software released under?

MIT

Who holds the private keys?

  • Users have access to their private keys and seed phrases
  • No one else has access
  • If the company/project were to disappear, users would still be able to access their funds

Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible

Has the wallet's smart contract code or security modules been audited?

https://github.com/RabbyHub/Rabby/blob/develop/docs/SlowMist%20Audit%20Report%20-%20Rabby%20Wallet-2023.07.20.pdf

Does the wallet have an internal security team?

We have dedicated security engineers

Any other security testing that should be noted?

  • We invite professional security agencies to conduct security audits of the code every year
  • We lock the versions of all external dependencies and will not update them easily unless necessary
  • Every time we update external dependencies, the Security Engineer will check the code change of dependencies to find if there is any malicious code

Scam protection?

  • We do have transaction simulation
  • We parse transaction action into readable human language instead of 0x codes
    image
  • We also have security rules to remind users of potential risk
    image

Does the wallet support connecting to Ethereum applications?

https://github.com/RabbyHub/Rabby/tree/develop?tab=readme-ov-file#guideline-for-integrating-rabby-wallet

Does the wallet support connecting to a hardware wallet?

Yes

Does the wallet support importing Ethereum RPC endpoints?

https://x.com/Rabby_io/status/1604092212450660353

Does the wallet support viewing and interacting with NFTs?

Yes

Does the wallet support staking directly?

No

Does the wallet support swaps directly?

https://x.com/Rabby_io/status/1673300387737075714

Does the wallet support bridging directly?

Yes, user can bridging asset via Bungee or LiFi via Rabby

Does the wallet support multi-chain networks?

Yes, we have native support 104 chains currently

Does the wallet support Ethereum layer 2 networks?

Yes, including Arbitrum, Arbitrum Nova, Astar zkEVM, Aurora, Base, Blast, Boba, Cyber, DBK Chain, Fraxtal, Karak, Metis, Mint, Mode, Linea, OP, Polygon zkEVM, Scroll, zkSync Era, Zora

Does the wallet allow the user to customize gas fees?

Yes, user can change it on signing page

Does the wallet support sending transactions to ENS addresses?

No

Does the wallet support importing or automatically querying and displaying ERC-20 tokens?

Yes, all DeBank support ERC-20 tokens will native support in Rabby

Does the wallet support EIP-1559 (type 2) transactions?

Yes, Rabby support Legacy(type 0) and Eip-1559(type 2) transactions

Does the wallet have any recovery options?

No, user needs to backup private keys and seed phrase, if user lost them, Rabby can not help to recovery

Does the wallet have fiat on-ramps through credit/debit cards, wire transfers, or bank transfers (ACH)?

No

Does the wallet support withdrawals to fiat?

No

Is the wallet a multi-signature wallet?

No response

Does the wallet support social recovery?

No response

Does the wallet support bundled transactions?

No

Who can the ethereum.org team can contact regarding the wallet in future?

Telegram: @galendefi
Twitter: galenyuan

Does the wallet have a dedicated support team?

Yes, we have Discord and Email support team
https://discord.com/invite/seFBCWmUre
[email protected]
all questions will be answered in 1 working day

What educational resources/documentation do you provide to users?

developer documentation: https://github.com/rabbyHub/rabby?tab=readme-ov-file#rabby-wallet

Does the wallet have any integrated tools not mentioned above?

No response

Would you like to work on this issue?

  • Yes
  • No
@vvvvvv1vvvvvv vvvvvv1vvvvvv added product 🧰 This involves a product listing wallet 👛 This issue relates to adding or changing a wallet labels Jul 24, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jul 24, 2024
@wackerow wackerow added awaiting PR Issue is ready for a pull request and removed needs triage 📥 This issue needs triaged before being worked on labels Jul 24, 2024
@wackerow
Copy link
Member

Lgtm, thanks @vvvvvv1vvvvvv! @konopkja, any info you're looking for that may be missing?

@wackerow wackerow changed the title Suggest a wallet Update: Rabby Wallet Jul 24, 2024
@konopkja
Copy link
Contributor

konopkja commented Jul 24, 2024

Screenshot 2024-07-24 at 19 29 30

would be good to know all ethereum rollups that are natively supported inside the wallet @vvvvvv1vvvvvv, otherwise lgtm! but this list looks like it contains most of it already, correct?

@vvvvvv1vvvvvv
Copy link
Contributor Author

Screenshot 2024-07-24 at 19 29 30

would be good to know all ethereum rollups that are natively supported inside the wallet @vvvvvv1vvvvvv, otherwise lgtm! but this list looks like it contains most of it already, correct?

updated the list

@konopkja
Copy link
Contributor

konopkja commented Jul 24, 2024

thank you, issue lgtm now! - needs PR

@vvvvvv1vvvvvv
Copy link
Contributor Author

#13480 PR created

wackerow added a commit that referenced this issue Jul 26, 2024
use as initial example of ChainName type restriction; data ref: #13469
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 24, 2024
@minimalsm
Copy link
Contributor

Closed in #13480, thanks @vvvvvv1vvvvvv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting PR Issue is ready for a pull request product 🧰 This involves a product listing Status: Stale This issue is stale because it has been open 30 days with no activity. wallet 👛 This issue relates to adding or changing a wallet
Projects
None yet
Development

No branches or pull requests

4 participants