Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking product cards - URLs are switched #6245

Closed
samajammin opened this issue May 6, 2022 · 0 comments · Fixed by #6275
Closed

Staking product cards - URLs are switched #6245

samajammin opened this issue May 6, 2022 · 0 comments · Fixed by #6275
Labels
bug 🐛 Something isn't working

Comments

@samajammin
Copy link
Member

samajammin commented May 6, 2022

Describe the bug

Occasionally when loading the staking pools page there's a couple issues:

  1. product URLs are incorrect/switched (e.g. Lido & Rocketpool are swapped)
  2. product image sizing is broken - some are small, some are cropped
  3. product feature icons are broken (e.g. are the black icons supposed to be x's?)

e.g.
Screen Shot 2022-05-06 at 11 41 52 AM

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://ethereum.org/en/staking/pools/
  2. See error on product cards

Expected behavior

Cards should display consistent image sizes & correct URLs.

Screenshots

See above.

Desktop (please complete the following information):

All.

Smartphone (please complete the following information):

All.

Additional context

These doesn't seem to happen consistently, e.g. after refreshing the page they appeared fine. I'm not sure what the issue is that's causing it. I suspect it has something to do with the shuffling of products before we display them... somehow the properties are getting jumbled?

I thought it may have been an issue with not having element IDs when rendering a map of sibling components but adding ids doesn't seem to have fixed the issue: #6070

Want to contribute?

We love contributions from the Ethereum community! Please comment on an issue if you're interested in helping out with a PR.

@samajammin samajammin added the bug 🐛 Something isn't working label May 6, 2022
samajammin added a commit that referenced this issue May 10, 2022
Staking product card layout fix [Fixes #6245]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant