Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds twFlipForRtl cn export to useRtlFlip #13632

Merged
merged 3 commits into from
Aug 16, 2024
Merged

feat: adds twFlipForRtl cn export to useRtlFlip #13632

merged 3 commits into from
Aug 16, 2024

Conversation

wackerow
Copy link
Member

Description

  • Updates the useRtlFlip custom hook to return txFlipForRtl with tailwind class -scale-x-1 to horizontally flip elements
  • Marked as the preferred method over using the transform value, and mark existing as deprecated
  • Keeps existing flipForRtl export unchanged for temporary backward compatibility

Related Issue

Tailwindcss migration

@pettinarip Would this be useful or do you see another approach here?

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Aug 13, 2024
Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit e9014b3
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66bc686e38784d0008977c1f
😎 Deploy Preview https://deploy-preview-13632--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 44 (🔴 down 4 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (🔴 down 14 from production)
SEO: 93 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow wackerow merged commit b7e4be2 into dev Aug 16, 2024
6 checks passed
@wackerow wackerow deleted the tw-use-rtl-flip branch August 16, 2024 01:24
This was referenced Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants