Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ShadCN] refactor(pages/staking): migrate page to ShadCN #13675

Merged

Conversation

TylerAPfledderer
Copy link
Contributor

Description

Migrate page to use ShadCN/Tailwind and import the new UI components used.

Copy link

netlify bot commented Aug 17, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit b0a4a7d
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66c468a71b761000082221f0
😎 Deploy Preview https://deploy-preview-13675--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 49 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer TylerAPfledderer marked this pull request as ready for review August 19, 2024 02:23
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TylerAPfledderer nice!

Left a couple of comments for @nloureiro to confirm. Once we are ok there, this is ready to be merged 👍🏼

src/pages/staking/index.tsx Show resolved Hide resolved
src/pages/staking/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT now 🚀

@pettinarip pettinarip merged commit 5d32204 into ethereum:dev Aug 20, 2024
8 of 9 checks passed
@TylerAPfledderer TylerAPfledderer deleted the refactor/staking-page-shadcn branch August 20, 2024 12:13
This was referenced Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants