Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadcn migration - GlossaryDefinition #13850

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Shadcn migration - GlossaryDefinition #13850

merged 3 commits into from
Sep 12, 2024

Conversation

saurabhburade
Copy link
Contributor

Description

Migrate GlossaryDefinition to tailwind.

@netlify Netlify
Copy link

netlify bot commented Sep 11, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg canceled.

Name Link
🔨 Latest commit f84b255
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66e308c18192a6000818ceb9

@saurabhburade saurabhburade marked this pull request as ready for review September 11, 2024 17:44
pettinarip
pettinarip approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @saurabhburade ty

src/components/Glossary/GlossaryDefinition/index.tsx Outdated Show resolved Hide resolved
@pettinarip pettinarip merged commit df87cb8 into ethereum:dev Sep 12, 2024
6 of 7 checks passed
This was referenced Sep 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pettinarip pettinarip pettinarip approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saurabhburade @pettinarip