Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused token #13952

Merged
merged 1 commit into from
Sep 25, 2024
Merged

chore: remove unused token #13952

merged 1 commit into from
Sep 25, 2024

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Sep 24, 2024

Description

  • Token accent-a-low-constrast was added in development of the ValuesMarquee component, but was ultimately not used. PR removes all traces
  • Removed TODO about color clash: primary-action/primary-action-hover applied specifically to solid buttons and should not clash with text link primary, primary-hover, and primary-visited

Related Issue

Ongoing theming cleanup

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 62baba1
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66f301b2d8ea6e00089cf258
😎 Deploy Preview https://deploy-preview-13952--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 41 (🔴 down 5 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip pettinarip merged commit 5c4b366 into dev Sep 25, 2024
8 of 10 checks passed
@pettinarip pettinarip deleted the rm-unused-token branch September 25, 2024 09:13
This was referenced Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants