refactor: components using old theming #13955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partial tailwind migration to fix colors
migrate qr-code pngs
wackerow
requested review from
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Looks good @wackerow thanks for the migration of these components. Left a small request.
| @@ -4,7 +4,6 @@ import { | |||
| Box, | |||
| chakra, | |||
| ChakraProps, | |||
| Circle, | |||
| HStack, | |||
| Stack, | |||
| Text, | |||
There was a problem hiding this comment.
Is it possible to migrate this component completely to Tw? I feel that we only need to change a few components and avoid leaving this in a hybrid situation.
There was a problem hiding this comment.
@pettinarip I started that and it led to a few complications that I didn't anticipate. For the sake of keeping scope of this PR trimmed to just the color updates, mind if I branch off and patch this up separately?
There was a problem hiding this comment.
Got it. Sure, we can tackle that separately.
pettinarip
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated to tailwind; colors updated to use latest theming
Related Issue
Theming updates