Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: homepage code example RTL layout #14044

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Fix: homepage code example RTL layout #14044

merged 5 commits into from
Oct 23, 2024

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Oct 3, 2024

Description

  • Forces entire mobile Accordion to dir="ltr" to keep loading skeleton and copy button positioned correctly
  • Forces desktop loading skeleton to dir="ltr", and forces desktop copy button to right- instead of end- since the code will always be ltr (so we don't want the copy button to move to the left, even on rtl locales)
  • Updates ui/accordion to use ChevronNext (direction responsive form of MdChevronRight), and adds rotate tailwind class to reverse rotation direction if rtl direction is inherited.

Preview link

https://deploy-preview-14044--ethereumorg.netlify.app/ur/

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit c6b7c03
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67000211475eb800089b1403
😎 Deploy Preview https://deploy-preview-14044--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 5 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines self-assigned this Oct 23, 2024
@corwintines corwintines merged commit 2bac5c9 into dev Oct 23, 2024
10 checks passed
@corwintines corwintines deleted the rtl-patches branch October 23, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants