Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ledger's metadata #14218

Merged
merged 12 commits into from
Nov 21, 2024
Merged

Update ledger's metadata #14218

merged 12 commits into from
Nov 21, 2024

Conversation

CremaFR
Copy link
Contributor

@CremaFR CremaFR commented Oct 23, 2024

Description

Related Issue

Soon

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 5afa599
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/673effdd0f299b0008d6b005
😎 Deploy Preview https://deploy-preview-14218--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 49 (🔴 down 5 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@rkhadem4 rkhadem4 mentioned this pull request Oct 30, 2024
@@ -193,7 +192,8 @@ export const getStaticProps = (async ({ locale }) => {
metricResults,
rssData: { rssItems, blogLinks },
},
revalidate: REVALIDATE_TIME,
// TODO: re-enable revalidation once we have a workaround for failing builds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the changes unrelated to ledger's metadata from the PR

@minimalsm
Copy link
Contributor

Thanks for the PR @CremaFR !

@minimalsm
Copy link
Contributor

@all-contributors please add @CremaFR for docs

@minimalsm minimalsm merged commit dbfe392 into ethereum:dev Nov 21, 2024
5 of 6 checks passed
Copy link

gitpoap-bot bot commented Nov 21, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Copy link
Contributor

@minimalsm

I've put up a pull request to add @CremaFR! 🎉

This was referenced Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants