-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync glossaries between eth.org, ethdocs.org & eth.wiki #5978
Conversation
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 9m PerformanceLighthouse report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks good.
I'd like some other input on these to make sure we think they fit into our current listing criteria:
- This is a term not already found in the glossary (for similar terms, please consider the benefits of a new term vs updating an existing term)
- This term/definition is not a product advertisement or contain other promotional content
- This term/definition is directly relevant to Ethereum
One thing we should be careful of is not try to cram every computer science related term into the glossary because Ethereum makes use of it in some way.
Co-authored-by: Joshua <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmcook1186 Juicy =) Went through all the ones you included in the PR and made comments. I'm cool with starting here, and the other options you left in the PR description can be always be raised as issues and added independently.
Thanks again for your work on this!
### cryptoeconomics {#cryptoeconomics} | ||
|
||
The economics of cryptocurrencies. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for now but the argument could be made that this is too narrow and should encompass peer-to-peer cryptographic systems generally. Is that what you were thinking @wackerow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(but happy to ignore this for now for the sake of speed)
src/content/glossary/index.md
Outdated
### presale {#presale} | ||
|
||
Sale of cryptocurrency before the actual launch of the network. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we note that this was a form of initial ETH issuance that did not come from actual proof-of-work mining or proof-of-stake validating? Okay with just keeping it simple too, just a thought
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should explain this somewhere on the site, but not here. One (crude) way I've heard it put is glossaries should focus on definitions, not trivia.
Co-authored-by: Paul Wackerow <[email protected]> Co-authored-by: Joshua <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉🎉
Description
This PR collects together entries in the ethdocs.org and eth.wiki glossaries and merges them into the glossary on ethereum.org. There are quite a few new additions. There were also many entries in the glossaries of both ethdocs.org and eth.wiki that I decided NOT to merge into ethereum.org. These are listed below so the PR reviewers can challenge any that they think are actually useful to include (especially those from ethdocs relating to trust and identity - I excluded them as superfluous but think they might actually be quite nice to include).
Entries from ethdocs NOT merged into ethereum.org in this PR:
Entries from eth.wiki NOT merged into ethereum.org in this PR:
Related Issue
#5731
#5690