Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS migration - second iteration #6412

Merged
merged 27 commits into from
May 25, 2022
Merged

TS migration - second iteration #6412

merged 27 commits into from
May 25, 2022

Conversation

pettinarip
Copy link
Member

@pettinarip pettinarip commented May 20, 2022 •
edited
Loading

Second iteration on the TS migration.

Things included in this PR:

  • Few migrations on each folder we have to serve as examples on how to migrate each one of them.
  • Enable graphqlTypegen: true to have graphql query types. https://www.gatsbyjs.com/docs/reference/release-notes/v4.15/#graphql-typegen
  • Removal of tests files and configs.
  • Fixed some older eslint warnings.
  • Expose a custom .babelrc file for compatibility with lambda functions running netlify dev
  • Updated docs.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies review needed 👀 labels May 20, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented May 20, 2022 •
edited
Loading

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 26m

Performance

Lighthouse report

Metric Score
Performance 🔶 19
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 92

🔗 View full report

pettinarip
pettinarip commented May 23, 2022
View reviewed changes
.babelrc Show resolved Hide resolved
pettinarip
pettinarip commented May 23, 2022
View reviewed changes
.prettierignore Outdated Show resolved Hide resolved
pettinarip
pettinarip commented May 23, 2022
View reviewed changes
gatsby-config.ts Outdated Show resolved Hide resolved
pettinarip
pettinarip commented May 23, 2022
View reviewed changes
src/pages/index.tsx Outdated Show resolved Hide resolved
@pettinarip pettinarip marked this pull request as ready for review May 24, 2022 15:02
@pettinarip pettinarip self-assigned this May 24, 2022
samajammin
samajammin reviewed May 24, 2022
View reviewed changes
README.md Show resolved Hide resolved
samajammin
samajammin reviewed May 24, 2022
View reviewed changes
README.md Show resolved Hide resolved
samajammin
samajammin reviewed May 24, 2022
View reviewed changes
gatsby-config.ts Outdated Show resolved Hide resolved
samajammin
samajammin reviewed May 24, 2022
View reviewed changes
gatsby-node.ts Outdated Show resolved Hide resolved
samajammin
samajammin reviewed May 24, 2022
View reviewed changes
src/components/Staking/StakingStatsBox.js
@@ -57,12 +57,6 @@ const ErrorMessage = () => (
</IndicatorSpan>
)

const LoadingMessage = () => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wackerow we should have a loading state here, ya 😄? Future PR...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed that because it was not being used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep... still needs to be fixed separately

samajammin
samajammin approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🙌 - LGTM!

Tested this out locally & things are looking good 👍👍:

  • yarn start works as expected
  • netlify dev --framework=gatsby works as expected
  • yarn build && yarn serve works as expected

wackerow
wackerow approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... working great locally (yarn start, netlify dev --framework=gatsby and yarn build && yarn serve), preview deploys look good with spot check.

@pettinarip pettinarip merged commit 66c6fb7 into dev May 25, 2022
@pettinarip pettinarip deleted the ts-second-iteration branch May 25, 2022 18:51
This was referenced May 25, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@corwintines corwintines corwintines approved these changes

@samajammin samajammin samajammin approved these changes

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees

@pettinarip pettinarip

Labels
content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pettinarip @samajammin @corwintines @wackerow @minimalsm