Glossary hash link patch #7010
Merged
Glossary hash link patch #7010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wackerow
requested review from
samajammin,
corwintines,
pettinarip and
minimalsm
as code owners
minimalsm
reviewed
Jul 11, 2022
src/components/Link.tsx
Outdated
| @@ -97,7 +97,7 @@ const Link: React.FC<IProps> = ({ | |||
|
|
|||
| const isExternal = to.includes("http") || to.includes("mailto:") | |||
| const isHash = isHashLink(to) | |||
| const isGlossary = to.includes("glossary#") | |||
| const isGlossary = to.includes("glossary" && "#") | |||
There was a problem hiding this comment.
String.includes only accepts 1 argument so this will ignore "glossary" match any link including "#".
Suggested change
| const isGlossary = to.includes("glossary" && "#") | |
| const isGlossary = to.includes("glossary") && to.includes("#") |
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 32m PerformanceLighthouse report
|
minimalsm
approved these changes
Jul 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
glossary#