Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword section of state channels developer doc #7260

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Reword section of state channels developer doc #7260

merged 2 commits into from
Aug 1, 2022

Conversation

gorondan
Copy link
Contributor

@gorondan gorondan commented Jul 31, 2022 •
edited
Loading

Typo / expression correction

Typo / expression correction in the State Channels section of the file

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Jul 31, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 31, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 34m

minimalsm
minimalsm approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gorondan for the PR ❤️ The original wasn't a typo, though on reading it back I realise that it uses very colloquial English that non-native speakers or folks from certain regions might not understand. I've amended this so that it is hopefully clearer but keeps the original meaning.

Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳!

@minimalsm
Copy link
Contributor

@all-contributors please add @gorondan for docs

@allcontributors allcontributors bot mentioned this pull request Aug 1, 2022
Merged
@allcontributors
Copy link
Contributor

@minimalsm

I've put up a pull request to add @gorondan! 🎉

@minimalsm minimalsm changed the title Update index.md Reword section of state channels developer doc Aug 1, 2022
@minimalsm minimalsm merged commit d9d0237 into ethereum:dev Aug 1, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Aug 1, 2022

Woohoo, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Ethereum.org Contributor:

Head on over to GitPOAP.io and connect your GitHub account to mint!

@gorondan
Copy link
Contributor Author

gorondan commented Aug 1, 2022

glad to be able to start contributing with an accepted pull request ❤️, even if a trivial one. will join discord community and looking forward to contributing to the project from now on.

@corwintines corwintines mentioned this pull request Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimalsm minimalsm minimalsm approved these changes

@samajammin samajammin Awaiting requested review from samajammin

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gorondan @minimalsm