This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
CLI Interface Refactor #1001
Merged
CLI Interface Refactor #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajlopez Could you, please, merge latest develop into your branch and push it. We had an issues with tests, now tests are fixed. |
ajlopez
force-pushed
the
cli_interface
branch
from
d1d7d22 to
30786ea
Compare
zilm13
suggested changes
Feb 11, 2018
| } | ||
|
|
||
| private static Boolean interpret(String arg) { | ||
| if ("on".equals(arg) || "true".equals(arg) || "yes".equals(arg)) return true; |
There was a problem hiding this comment.
Could you replace both lines in favor of BooleanUtils.toBooleanObject(String) with throwing error when null returned. I guess it would be safer.
There was a problem hiding this comment.
Add something like
if (resetFlag == null) {
throw new Error(String.format("Can't interpret DB reset arguments: %s %s", arg, reset));
}
You've lost this case
There was a problem hiding this comment.
Sure, good catch... done
ajlopez
force-pushed
the
cli_interface
branch
from
30786ea to
3785290
Compare
zilm13
approved these changes
Feb 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactors, suggested by a linter (Sonar):
I think it could be improved. For example, to have a class that processes an array of arguments, and returns a map of key values... and separate the apply of those key values to SystemProperties. In this way, we could have tests with expected behavior and better code coverage