This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Increase coverage for .config.blockchain #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weisheme
force-pushed
the
increase_test_coverage_fork_config_rules
branch
from
0a3d22d to
8114746
Compare
- Replaced System.out with Logger in TransactionTest - TransactionTest.afterEIP158Test() seems to expose a modeling issue. `v = CHAIN_ID * 2 + 36` is never stored in Transaction.signature field.
weisheme
force-pushed
the
increase_test_coverage_fork_config_rules
branch
from
8114746 to
7469351
Compare
|
@weisheme Nice! Much appreciate you keep working on tests! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransactionTest.afterEIP158Test()seems to expose a modeling issue. The required EIP-155 change ofv = CHAIN_ID * 2 + 36is never stored in Transaction.signature field.