Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename EVMC_STORAGE_MODIFIED_DIRTY to EVMC_STORAGE_MODIFIED_AGAIN #132

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Rename EVMC_STORAGE_MODIFIED_DIRTY to EVMC_STORAGE_MODIFIED_AGAIN #132

merged 3 commits into from
Sep 5, 2018

Conversation

axic
Copy link
Member

@axic axic commented Sep 3, 2018 •
edited
Loading

Fixes #127.
Closes #129.

@axic axic requested review from chfast and gumb0 September 3, 2018 20:54
chfast
chfast reviewed Sep 3, 2018
View reviewed changes
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with the wording in EIP-1283.

If original value does not equal current value (this storage slot is dirty)

@chfast
Copy link
Member

chfast commented Sep 3, 2018

How about EVMC_STORAGE_DIRTY_MODIFIED?

@axic
Copy link
Member Author

axic commented Sep 3, 2018

This conflicts with the wording in EIP-1283.

Are you claiming that evmc 100% matches the wording of random EIPs / YP / all random clients ? 😉

gumb0
gumb0 approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@gumb0 gumb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like EVMC_STORAGE_MODIFIED_AGAIN more

@chfast chfast merged commit 62ed4a1 into master Sep 5, 2018
@chfast chfast deleted the storagestore branch September 5, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gumb0 gumb0 gumb0 approved these changes

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axic @chfast @gumb0