Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage status #52

Merged
merged 3 commits into from
Aug 9, 2018
Merged

Storage status #52

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cf24c7
Extend set_storage() by reporting the storage status
chfast Aug 8, 2018
e16f19e
examples: Rename evm_log() to emit_log()
chfast Aug 8, 2018
380ff4f
Extend the documentation of evmc_storage_status
chfast Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions examples/capi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,12 @@ static void get_block_hash(struct evmc_uint256be* result,
}

/// EVM log callback.
///
/// @note The `evm_log` name is used to avoid conflict with `log()` C function.
static void evm_log(struct evmc_context* context,
const struct evmc_address* address,
const uint8_t* data,
size_t data_size,
const struct evmc_uint256be topics[],
size_t topics_count)
static void emit_log(struct evmc_context* context,
Copy link
Member

@axic axic Aug 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack this change. Needs an ABI bump.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ABI is bumped in this PR already, but that's not needed in this case, because this is a static function in a example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right I thought it was renaming the member, but that was renamed before.

const struct evmc_address* address,
const uint8_t* data,
size_t data_size,
const struct evmc_uint256be topics[],
size_t topics_count)
{
(void)context;
(void)address;
Expand All @@ -161,7 +159,7 @@ static void evm_log(struct evmc_context* context,

static const struct evmc_context_fn_table ctx_fn_table = {
account_exists, get_storage, set_storage, get_balance, get_code_size, get_code_hash,
copy_code, selfdestruct, call, get_tx_context, get_block_hash, evm_log,
copy_code, selfdestruct, call, get_tx_context, get_block_hash, emit_log,
};

/// Example how the API is supposed to be used.
Expand Down