Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eof: Return constant hash of EXTCODEHASH of EOF #1035

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 27, 2024

Replace runtime evaluated keccak256("EF00") with a constant returned for an account with EOF code.

@chfast chfast requested review from gumb0 and pdobacz September 27, 2024 21:35
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (2cd8bf7) to head (02b6951).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1035   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         153      153           
  Lines       15927    15933    +6     
=======================================
+ Hits        15005    15011    +6     
  Misses        922      922           
Flag Coverage Δ
eof_execution_spec_tests 17.53% <75.00%> (+0.01%) ⬆️
ethereum_tests 27.34% <66.66%> (+<0.01%) ⬆️
ethereum_tests_silkpre 19.15% <45.45%> (+0.01%) ⬆️
execution_spec_tests 20.45% <41.66%> (+0.01%) ⬆️
unittests 89.00% <91.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone/eof.cpp 85.68% <100.00%> (ø)
lib/evmone/eof.hpp 100.00% <ø> (ø)
test/state/host.cpp 100.00% <100.00%> (ø)
test/unittests/eof_test.cpp 94.00% <100.00%> (+0.25%) ⬆️

Replace runtime evaluated `keccak256("EF00")` with a constant returned
for an account with EOF code.
@chfast chfast merged commit 46dc5ee into master Sep 30, 2024
25 checks passed
@chfast chfast deleted the eof/extcodehash branch September 30, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants