Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests visualizing underlying RLP for create address #1054

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 15, 2024

No description provided.

@chfast chfast requested review from gumb0, pdobacz and rodiazet October 15, 2024 15:57
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.23%. Comparing base (589c1d6) to head (e5cc0a4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1054   +/-   ##
=======================================
  Coverage   94.23%   94.23%           
=======================================
  Files         155      155           
  Lines       15982    16004   +22     
=======================================
+ Hits        15060    15082   +22     
  Misses        922      922           
Flag Coverage Δ
eof_execution_spec_tests 17.72% <0.00%> (-0.03%) ⬇️
ethereum_tests 27.49% <0.00%> (-0.04%) ⬇️
ethereum_tests_silkpre 19.30% <0.00%> (-0.04%) ⬇️
execution_spec_tests 20.55% <0.00%> (-0.03%) ⬇️
unittests 89.04% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/unittests/state_new_account_address_test.cpp 100.00% <100.00%> (ø)

@chfast chfast force-pushed the tests/create_address branch from cb7b72e to 01c052b Compare October 16, 2024 13:29
@chfast chfast force-pushed the tests/create_address branch from 01c052b to e5cc0a4 Compare October 16, 2024 13:52
@chfast
Copy link
Member Author

chfast commented Oct 16, 2024

I decide to rework it even more to have all cases for RLP nonce encoding, needed for #783.

@chfast chfast merged commit bbd7e03 into master Oct 16, 2024
25 checks passed
@chfast chfast deleted the tests/create_address branch October 16, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants