Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

state: Implement CREATE address without RLP lib #1055

Merged
merged 2 commits into from
Oct 23, 2024
Merged

state: Implement CREATE address without RLP lib #1055

merged 2 commits into from
Oct 23, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 17, 2024

Remove Host's dependency on RLP library by re-implementing compute_create_address().

Closes #783.

@chfast chfast mentioned this pull request Oct 17, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.23%. Comparing base (b0f6707) to head (d2b9dc2).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1055   +/-   ##
=======================================
  Coverage   94.23%   94.23%           
=======================================
  Files         155      155           
  Lines       17005    17014    +9     
=======================================
+ Hits        16024    16033    +9     
  Misses        981      981
Flag Coverage Δ
eof_execution_spec_tests 17.45% <64.28%> (+0.02%) ⬆️
ethereum_tests 26.92% <92.85%> (+0.03%) ⬆️
ethereum_tests_silkpre 19.04% <90.90%> (+0.04%) ⬆️
execution_spec_tests 20.18% <64.28%> (+0.01%) ⬆️
unittests 89.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/state/host.cpp 100.00% <100.00%> (ø)
test/unittests/state_new_account_address_test.cpp 100.00% <100.00%> (ø)

@chfast chfast force-pushed the tests/create_address branch from 5cd6901 to a9468d4 Compare October 18, 2024 09:50
@chfast chfast marked this pull request as ready for review October 18, 2024 09:51
@chfast chfast requested review from gumb0 and pdobacz October 18, 2024 09:51
@chfast chfast force-pushed the tests/create_address branch 3 times, most recently from 78af74a to 07eb905 Compare October 18, 2024 10:35
pdobacz
pdobacz approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one naming nitpick

@chfast chfast force-pushed the tests/create_address branch from 07eb905 to 68eba83 Compare October 18, 2024 13:37
chfast added 2 commits October 23, 2024 21:57
@chfast
test: Add create address tests sensitive to endianness
1f11e4c
@chfast
state: Implement CREATE address without RLP lib
d2b9dc2 
Remove Host's dependency on RLP library by re-implementing
`compute_create_address()`.

Closes #783.
@chfast chfast force-pushed the tests/create_address branch from 68eba83 to d2b9dc2 Compare October 23, 2024 19:57
@chfast chfast enabled auto-merge October 23, 2024 19:58
@chfast chfast merged commit c8787ec into master Oct 23, 2024
23 checks passed
@chfast chfast deleted the tests/create_address branch October 23, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdobacz pdobacz pdobacz approved these changes

@gumb0 gumb0 Awaiting requested review from gumb0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compute CREATE address without RLP library
2 participants
@chfast @pdobacz