ci: Add Silkworm-driven consensus tests #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
approved these changes
Feb 19, 2021
axic
reviewed
Feb 19, 2021
circle.yml
Outdated
| at: ~/package | ||
| - run: | ||
| name: "Unpack evmone" | ||
| background: true |
There was a problem hiding this comment.
So this runs parallel? Does it really take that much time to risk any potential wrong order execution here?
axic
reviewed
Feb 19, 2021
| paths: | ||
| - ~/silkworm/consensus | ||
|
|
||
| download_consensus_tests: |
There was a problem hiding this comment.
Why not cache this too? Takes 16 seconds, and running the tests is 13.
There was a problem hiding this comment.
Cache means you have to download and unpack it, just from different server.
There was a problem hiding this comment.
Ah ok, I thought it is some better integration with circleci.
chfast
force-pushed
the
silkworm_consensus_tests
branch
from
c07624c to
0bcafb7
Compare
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 24 24
Lines 3655 3655
=======================================
Hits 3646 3646
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. |
axic
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.