Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EVMC #330

Closed
wants to merge 1 commit into from
Closed

Upgrade EVMC #330

wants to merge 1 commit into from

Conversation

chfast
Copy link
Member

@chfast chfast commented May 21, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #330 (4269cd9) into master (0aba799) will not change coverage.
The diff coverage is n/a.

❗ Current head 4269cd9 differs from pull request most recent head d65938a. Consider uploading reports for the commit d65938a to get more accurate results

@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          28       28           
  Lines        3979     3979           
=======================================
  Hits         3970     3970           
  Misses          9        9           
Flag Coverage Δ
consensus 95.29% <ø> (ø)
unittests 99.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@axic
Copy link
Member

axic commented May 21, 2021

The tgz artifact in the release-linux job still only contains bin/evmone-bench and nothing else.

@chfast
Copy link
Member Author

chfast commented May 21, 2021

The tgz artifact in the release-linux job still only contains bin/evmone-bench and nothing else.

This is controlled by CMake install(). I believe we don't install EVMC therefore binaries are not included.

@chfast
Copy link
Member Author

chfast commented May 28, 2021

Included in #333.

@chfast chfast closed this May 28, 2021
@chfast chfast deleted the upgrade_evmc branch May 28, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants