baseline: Use custom instruction table #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 29 30 +1
Lines 4133 4134 +1
=======================================
+ Hits 4124 4125 +1
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Haswell 4.4 GHz, clang-12 |
gumb0
reviewed
Jun 9, 2021
lib/evmone/baseline.cpp
Outdated
|
|
||
| if (instruction_names[op] == nullptr) | ||
| if (metrics.gas_cost < 0) |
There was a problem hiding this comment.
maybe
Suggested change
| if (metrics.gas_cost < 0) | |
| if (metrics.gas_cost == instr::undefined) |
gumb0
reviewed
Jun 9, 2021
| const auto gas_cost = instr::gas_costs<Rev>[i]; | ||
| t.gas_cost = gas_cost; // Include instr::undefined in the table. | ||
| t.stack_height_required = instr::traits[i].stack_height_required; | ||
| t.can_overflow_stack = instr::traits[i].stack_height_change > 0; |
There was a problem hiding this comment.
Could add
static_assert(instr::traits[i].stack_height_change <= 1);
because the stack overflow check now assumes this.
gumb0
reviewed
Jun 9, 2021
| @@ -0,0 +1,21 @@ | |||
| // evmone: Fast Ethereum Virtual Machine implementation | |||
| // Copyright 2020 The evmone Authors. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2020 The evmone Authors. | |
| // Copyright 2021 The evmone Authors. |
There was a problem hiding this comment.
These commits are from December 2020 :)
chfast
force-pushed
the
baseline_instruction_table
branch
from
d53494e to
f5c2f1d
Compare
gumb0
approved these changes
Jun 10, 2021
chfast
force-pushed
the
baseline_instruction_table
branch
from
f5c2f1d to
f8900a2
Compare
|
New benchmarks for execute only: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously EVMC instruction tables were used (for quick head start).
Now two EVMC tables are replaced with single one. This at least cuts memory bandwidth from 12 bytes to 4 bytes per instruction.
Changes to instruction requirements checks are minimal but the stack overflow is checked differently.
The check can be further optimized but this will be done separately.