Use references to stack values in MCOPY #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 80 80
Lines 7739 7739
=======================================
Hits 7532 7532
Misses 207 207
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This disabled inlining of |
Is it strong enough reason to do extra copying of 3 |
Open
chfast
approved these changes
May 24, 2023
chfast
force-pushed
the
mcopy-args-reference
branch
2 times, most recently
from
42ce6d7 to
4e6e7d3
Compare
chfast
force-pushed
the
mcopy-args-reference
branch
from
4e6e7d3 to
68bef8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pop()returns a reference and we don't need to make an extra copy.Previous discussion: #629 (review)