EOF: TXCREATE instruction #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
eof-create4
branch
3 times, most recently
from
3f4d668 to
6fb21e1
Compare
gumb0
force-pushed
the
eof-create3
branch
2 times, most recently
from
cdd53d5 to
64374ea
Compare
gumb0
force-pushed
the
eof-create3
branch
2 times, most recently
from
bfe5b1e to
1197381
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
==========================================
+ Coverage 98.27% 98.32% +0.05%
==========================================
Files 129 129
Lines 14650 15515 +865
==========================================
+ Hits 14397 15255 +858
- Misses 253 260 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
force-pushed
the
eof-create4
branch
2 times, most recently
from
45f792f to
d869e2b
Compare
gumb0
force-pushed
the
eof-create3
branch
5 times, most recently
from
787bc15 to
8f2e254
Compare
gumb0
force-pushed
the
eof-create3
branch
5 times, most recently
from
544d807 to
bb66969
Compare
pdobacz
force-pushed
the
eof-create4
branch
3 times, most recently
from
f5f0a21 to
7341929
Compare
gumb0
force-pushed
the
eof-create3
branch
2 times, most recently
from
327f5ca to
7ba50d5
Compare
gumb0
force-pushed
the
eof-create3
branch
2 times, most recently
from
4a02f97 to
3599674
Compare
gumb0
force-pushed
the
eof-create4
branch
2 times, most recently
from
fd27842 to
17c09c7
Compare
chfast
reviewed
Apr 17, 2024
|
|
||
| initcontainer = | ||
| state.get_tx_initcode_by_hash(intx::be::store<evmc::bytes32>(initcode_hash)); | ||
| if (initcontainer.empty()) |
There was a problem hiding this comment.
Can you actually provide an empty initcontainer in the transaction?
There was a problem hiding this comment.
Actually you cannot, we forgot to remove this with the introduction of this rule.
You cannot, but state.get_tx_initcode_by_hash() returns empty bytes_view when initcontainer not found.
There was a problem hiding this comment.
I would change get_tx_initcode_by_hash returning std::optional
gumb0
force-pushed
the
eof-create4
branch
2 times, most recently
from
cb87439 to
9b4d832
Compare
rodiazet
reviewed
Apr 18, 2024
Co-authored-by: pdobacz <[email protected]>
Co-authored-by: pdobacz <[email protected]>
Including support in state test runner and in export from state transition tests.
chfast
approved these changes
Apr 18, 2024
rodiazet
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #553