eof: Improve RJUMPV tests #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gumb0
commented
Dec 21, 2023
gumb0
commented
- Replace CODECOPY with DATACOPY
- Use calldata argument instead of modifying code byte
- Split long jumps case into separate cases for min negative and max positive jumps
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #755 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 110 110
Lines 10535 10537 +2
=======================================
+ Hits 10314 10316 +2
Misses 221 221
Flags with carried forward coverage won't be shown. Click here to find out more.
|
- Replace CODECOPY with DATACOPY - Use calldata argument instead of modifying code byte - Split long jumps case into separate cases for min negative and max positive jumps
gumb0
force-pushed
the
eof/rjumpv-tests-improve
branch
from
d61d97a to
7fdc926
Compare
chfast
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.