Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output failed test case index in EOF validation tests #820

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Feb 16, 2024

Pulled out of #676

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (04247dd) 97.88% compared to head (fdad4c5) 97.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files         113      113           
  Lines       10630    10631    +1     
=======================================
+ Hits        10405    10406    +1     
  Misses        225      225           
Flag Coverage Δ
blockchaintests 59.88% <ø> (ø)
statetests 62.16% <ø> (ø)
statetests-silkpre 25.61% <0.00%> (ø)
unittests 95.87% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/unittests/eof_validation.cpp 85.71% <66.66%> (+2.38%) ⬆️

@gumb0 gumb0 requested review from chfast and pdobacz February 16, 2024 16:45
@gumb0 gumb0 merged commit 534d4e4 into master Feb 19, 2024
24 of 25 checks passed
@gumb0 gumb0 deleted the eof/output-failed-test-index branch February 19, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants