Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompiles: Add BLS precompiles IDs #984

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

rodiazet
Copy link
Contributor

@rodiazet rodiazet commented Sep 3, 2024

Preparation to implementation of EIP-2537: "Precompile for BLS12-381 curve operations".

@rodiazet rodiazet added precompiles Related to EVM precompiles Prague Changes for Prague upgrade labels Sep 3, 2024
@rodiazet rodiazet requested a review from chfast September 3, 2024 13:48
@rodiazet rodiazet force-pushed the bls-precompiles-prep branch from 2395483 to 7ee9268 Compare September 3, 2024 13:52
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 23.80952% with 48 lines in your changes missing coverage. Please review.

Project coverage is 94.01%. Comparing base (6974fd7) to head (4ded90a).

Files with missing lines Patch % Lines
test/state/precompiles.cpp 4.00% 48 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
- Coverage   94.29%   94.01%   -0.28%     
==========================================
  Files         143      143              
  Lines       16142    16200      +58     
==========================================
+ Hits        15221    15231      +10     
- Misses        921      969      +48     
Flag Coverage Δ
eof_execution_spec_tests 16.61% <0.00%> (-0.06%) ⬇️
ethereum_tests 26.50% <3.17%> (-0.09%) ⬇️
ethereum_tests_silkpre 18.61% <3.22%> (-0.07%) ⬇️
execution_spec_tests 17.67% <3.17%> (-0.06%) ⬇️
unittests 89.47% <23.80%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/unittests/state_precompiles_test.cpp 100.00% <100.00%> (ø)
test/state/precompiles.cpp 78.18% <4.00%> (-21.82%) ⬇️

@rodiazet rodiazet force-pushed the bls-precompiles-prep branch from 7ee9268 to 4ded90a Compare September 3, 2024 14:03
@rodiazet rodiazet force-pushed the bls-precompiles-prep branch 2 times, most recently from 86feea6 to 83bc986 Compare September 5, 2024 10:00
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit pedantics: use "BLS" name and link the EIP.

test/state/precompiles.cpp Outdated Show resolved Hide resolved
@rodiazet rodiazet changed the title precompiles: Add bls precompiles IDs precompiles: Add BLS precompiles IDs Sep 6, 2024
@rodiazet rodiazet force-pushed the bls-precompiles-prep branch from 83bc986 to 4ba906b Compare September 6, 2024 09:43
@rodiazet rodiazet force-pushed the bls-precompiles-prep branch from 4ba906b to 2a4405b Compare September 6, 2024 09:50
@chfast chfast enabled auto-merge (squash) September 6, 2024 09:53
@chfast chfast merged commit ec2fa02 into master Sep 6, 2024
23 checks passed
@chfast chfast deleted the bls-precompiles-prep branch September 6, 2024 10:03
rodiazet added a commit that referenced this pull request Sep 10, 2024
Implementation of the `bls12_g1add` precompile: E1 affine points'
addition from BLS12-381 curve according to the EIP-2537 spec
https://eips.ethereum.org/EIPS/eip-2537#abi-for-g1-addition.

Depends on #984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prague Changes for Prague upgrade precompiles Related to EVM precompiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants