Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): EIP-7702: update auth.chainid in set code txs to u256 #1026

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Dec 17, 2024

🗒️ Description

Updates the tests to use a u256 chain ID in 7702 set code txs.

🔗 Related Issues

Filling

Fills using:

fill tests/prague/eip7702_set_code_tx/ --fork=Prague -n auto

with the eels resolutions file:

{
    "Prague": {
        "git_url": "https://github.com/danceratopz/execution-specs.git",
        "branch": "eip-7702-chain_id-u256",
        "commit": "febb39764b8760715136981649773a1c48e98f8e"
    }
}

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.

@danceratopz danceratopz changed the title chore(tests): update chainid in 7702 set code txs to u256 chore(tests): update auth.chainid in 7702 set code txs to u256 Dec 18, 2024
@danceratopz danceratopz marked this pull request as draft December 18, 2024 15:27
@danceratopz
Copy link
Member Author

Marked as draft due to this counter proposal:

@danceratopz danceratopz added the fork:prague Prague hardfork label Dec 19, 2024
@marioevz marioevz marked this pull request as ready for review December 20, 2024 15:54
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz changed the title chore(tests): update auth.chainid in 7702 set code txs to u256 chore(tests): EIP-7702: update auth.chainid in set code txs to u256 Dec 20, 2024
@marioevz marioevz merged commit 1bdec80 into main Dec 20, 2024
5 checks passed
@marioevz marioevz deleted the chore/tests/update-chainid-to-u256 branch December 20, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:prague Prague hardfork scope:tests Scope: Test cases type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants