Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump go version from 1.20.5 to 1.21.x #484

Merged

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Mar 20, 2024

πŸ—’οΈ Description

Github Actions are currently failing to build geth; this PR bumps Github Action to build geth with Golang 1.21.

πŸ”— Related Issues

None

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added type:bug Something isn't working scope:ci Scope: Continuous Integration labels Mar 20, 2024
@danceratopz danceratopz changed the title fix: bump go version from 1.20.5 to 1.20.x fix: bump go version from 1.20.5 to 1.21.x Mar 20, 2024
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spencer-tb spencer-tb merged commit 44f0bba into ethereum:main Mar 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants