Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(test): a couple of account resurrection tests #488

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Mar 29, 2024

🗒️ Description

A couple of tests re. resurrection of accounts killed with SELFDESTRUCT. Though SELFDESTRUCT was neutered in Dencun, these tests are still of interest for historical logic. In particular, older versions of Erigon didn't pass these tests.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz
Copy link
Member

marioevz commented Apr 1, 2024

Hi @yperbasis thanks for implementing this :)
Took the liberty to fix some formatting and added some parameterization to reduce the amount of code.
This looks good to me to merge, so whenever you are ready just mark it as ready for review and I'll approve and merge 👍

@yperbasis yperbasis marked this pull request as ready for review April 2, 2024 07:14
@yperbasis
Copy link
Member Author

Hi @yperbasis thanks for implementing this :) Took the liberty to fix some formatting and added some parameterization to reduce the amount of code. This looks good to me to merge, so whenever you are ready just mark it as ready for review and I'll approve and merge 👍

Thank you Mario!

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marioevz marioevz merged commit e738983 into ethereum:main Apr 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants