-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fw): EOF support #512
Merged
+5,535
β34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsvega
added
scope:pytest
Scope: Changes EEST's pytest plugins
scope:tests
Scope: Changes EL client test cases in `./tests`
labels
Apr 17, 2024
winsvega
force-pushed
the
eof-tests
branch
2 times, most recently
from
April 17, 2024 10:46
8312053
to
582c46b
Compare
winsvega
commented
Apr 17, 2024
winsvega
commented
Apr 17, 2024
ok need to setup eof_test function to run throught the external eof verification tool |
danceratopz
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment on moving "constants" to a spec.py module that would get picked up by our docs workflow.
7 tasks
tools/vm: EOF opcode changes tools: CREATE3 helper tox: EOF Keywords post rebase changes: align EOF tests with main. Co-authored-by: spencer-tb <[email protected]> post rebase: tox fixes. Co-authored-by: spencer-tb <[email protected]> Fix existing EOF tests (#11) Co-authored-by: Hugo <[email protected]>
tests/eof: move to prague tests/eof: fixes post rebase changes: align EOF tests with main. (tests) Co-authored-by: spencer-tb <[email protected]> post rebase: tox fixes (tests). Co-authored-by: spencer-tb <[email protected]> Fix existing EOF tests (tests) (#11) Co-authored-by: Hugo <[email protected]>
lots of TODOs
marioevz
added
type:refactor
Type: Refactor
type:feat
type: Feature
scope:fw
Scope: Framework (evm|tools|forks|pytest)
labels
Apr 18, 2024
marioevz
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope:fw
Scope: Framework (evm|tools|forks|pytest)
scope:pytest
Scope: Changes EEST's pytest plugins
scope:tests
Scope: Changes EL client test cases in `./tests`
type:feat
type: Feature
type:refactor
Type: Refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ποΈ Description
Eof container structures and eof fixtures
π Related Issues
Need to align with this PRS
#494
#205
Issues
#500
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.