Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fw): EOF support #512

Merged
merged 42 commits into from
Apr 18, 2024
Merged

feat(fw): EOF support #512

merged 42 commits into from
Apr 18, 2024

Conversation

winsvega
Copy link
Contributor

@winsvega winsvega commented Apr 17, 2024

πŸ—’οΈ Description

Eof container structures and eof fixtures

πŸ”— Related Issues

Need to align with this PRS

#494
#205

Issues
#500

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega winsvega added scope:pytest Scope: Changes EEST's pytest plugins scope:tests Scope: Changes EL client test cases in `./tests` labels Apr 17, 2024
@winsvega winsvega force-pushed the eof-tests branch 2 times, most recently from 8312053 to 582c46b Compare April 17, 2024 10:46
@winsvega
Copy link
Contributor Author

ok need to setup eof_test function to run throught the external eof verification tool
and fix test generation in eof format and blockchain test format

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on moving "constants" to a spec.py module that would get picked up by our docs workflow.

tests/prague/eip3540_eof_v1/constants.py Outdated Show resolved Hide resolved
@marioevz marioevz changed the title Eof tests support feat(fw): EOF support Apr 18, 2024
@marioevz marioevz added type:refactor Type: Refactor type:feat type: Feature scope:fw Scope: Framework (evm|tools|forks|pytest) labels Apr 18, 2024
@marioevz marioevz merged commit e7d677b into main Apr 18, 2024
9 checks passed
@marioevz marioevz deleted the eof-tests branch May 3, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) scope:pytest Scope: Changes EEST's pytest plugins scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature type:refactor Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants