Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pytest): use --tb=short as default for fill test reports #542

Merged
merged 3 commits into from
May 6, 2024
Merged

feat(pytest): use --tb=short as default for fill test reports #542

merged 3 commits into from
May 6, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented May 2, 2024 •
edited
Loading

🗒️ Description

Set --tb=short in fill's pytest.ini for more compact test reports.

🔗 Related Issues

Comparison of different failure reports can be found #541.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added scope:pytest Scope: Changes EEST's pytest plugins type:feat type: Feature labels May 2, 2024
spencer-tb
spencer-tb approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :D

@winsvega
Copy link
Contributor

winsvega commented May 6, 2024

yes, I always use this flag anyway

@marioevz marioevz merged commit 12cacf6 into main May 6, 2024
9 checks passed
danceratopz added a commit to danceratopz/execution-spec-tests that referenced this pull request May 8, 2024
@danceratopz
feat(consume): use --tb=short for pytest backtraces cf ethereum#542
18611cd 
As introduced for `fill` in ethereum#542.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

Assignees
No one assigned
Labels
scope:pytest Scope: Changes EEST's pytest plugins type:feat type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danceratopz @winsvega @spencer-tb @marioevz