-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EOF - EIP-3540: MAX_INITCODE_SIZE validation #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I feel like the eof_test
test type is not enough to test the initcode and deployed code max sizes. I feel like we require state tests for this, where we use contract-creating txs to test the maximum initcode size, and contract-creating txs + eofcreate to test the maximum size of deployed containers.
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_container_size.py
Outdated
Show resolved
Hide resolved
Agreed. This PR only adds tests for a specific addition from the PR cited, not meant to be exhaustive. The tests which you mention will be covered in the 7620 / 7698 tests department |
e49d60f
to
113b9f4
Compare
This is ready to be reviewed. @marioevz would you like to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some comments, I'll apply them and merge.
🗒️ Description
Add tests aligning with ethereum/EIPs#8670 / ipsilon/eof#125
🔗 Related Issues
na
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.