Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consume): add consume engine hive simulator #691

Merged
merged 12 commits into from
Jul 18, 2024
Merged

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Jul 18, 2024

🗒️ Description

Adds the consume engine hive simulator to EEST. This acts as an equivalent test runner to that of the hive pyspec simulator.

Now we can fill tests and instantly run them against clients executing blocks as engine_newPayloadVX's, to verify that the generated test fixture validates the client implementation.

Additionally it refactors the consume suite with the following:

  1. Remove tests_consume and move consumer tests: test_via_engine etc within src/pytest_plugins/consume/
  2. Hive specific simulators have there own folder: src/pytest_plugins/consume/hive_simulators/
  3. Utilize conftest.py within hive simulators to avoid overlap.
  4. Only use a single pytest-consume.ini file.

🔗 Related Issues

N/A

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added type:feat type: Feature scope:consume Scope: Consume command suite scope:fw Scope: Framework (evm|tools|forks|pytest) labels Jul 18, 2024
@spencer-tb spencer-tb force-pushed the consume-engine branch 2 times, most recently from 6694b0d to f5babca Compare July 18, 2024 16:26
@spencer-tb spencer-tb requested a review from marioevz July 18, 2024 21:16
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Awesome job! 😀

@marioevz marioevz merged commit bdd29dd into main Jul 18, 2024
7 checks passed
@marioevz marioevz deleted the consume-engine branch July 18, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:consume Scope: Consume command suite scope:fw Scope: Framework (evm|tools|forks|pytest) type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants